[ 
https://issues.apache.org/jira/browse/CALCITE-2847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16791905#comment-16791905
 ] 

Kevin Risden commented on CALCITE-2847:
---------------------------------------

Thanks [~zhztheplayer]. I pulled the PR locally and ran through some of the 
release checks to make sure it didn't break anything before merging. 

 

[~julianhyde] - Did you want to review before merging? The change is outside my 
area of understanding. I'll plan on merging in about ~8hrs unless there are 
issues with the review so I can continue with the 1.19.0 release.

> Optimize global LOOKAHEAD for SQL parsers
> -----------------------------------------
>
>                 Key: CALCITE-2847
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2847
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>            Reporter: Hongze Zhang
>            Assignee: Hongze Zhang
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.19.0
>
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> Currently global LOOKAHEAD is set to 2 for the built-in SQL parsers[1], we'd 
> like to optimize LOOKAHEAD to 1 to enable performance enhancement if possible.
> [1]https://github.com/apache/calcite/blob/883666929478aabe07ee5b9e572c43a6f1a703e2/core/pom.xml#L304



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to