[ 
https://issues.apache.org/jira/browse/CALCITE-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16796033#comment-16796033
 ] 

Stamatis Zampetakis commented on CALCITE-2934:
----------------------------------------------

Thanks for your feedback [~kgyrtkirk] . I am not against the simplification; I 
just wanted to highlight that this is a change which might break a few clients 
using Calcite. I guess you weighted the positive and negative side of the 
things so I trust you on this. There are ways to obtain the previous behavior 
so I will close this one.

> Simplification of a filter =($0, false) to NOT($0) ($0 is boolean)
> ------------------------------------------------------------------
>
>                 Key: CALCITE-2934
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2934
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Stamatis Zampetakis
>            Priority: Major
>             Fix For: 1.20.0
>
>
> The errors occur due to the simplification of a filter =($0, false) to 
> NOT($0) ($0 is boolean). The transformation is valid so in principle the 
> tests should not fail. However it makes me wonder if adding negation is 
> really a simplification. If  I want to push this expression into an index
> (e.g., B+Tree) I would have to rewrite it again to something equivalent to 
> =($0, false) since many types of indexes do not support negative conditions.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to