[
https://issues.apache.org/jira/browse/CALCITE-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16807377#comment-16807377
]
Julian Hyde commented on CALCITE-1581:
--------------------------------------
Reviewing:
* The parser changes seem OK. Please add tests to SqlParserTest, and document
the syntax in reference.md (noting that it is conformance-specific).
* Thanks for adding to SqlConformance.
* That's a lot of rewrite code. It doesn't belong in SqlValidatorImpl. Maybe in
SqlToRelConverter? It's usually best not to rewrite before validation -
otherwise the error messages don't make sense to the user. If you really must
rewrite before validation, could you use performUnconditionalRewrites? And move
the code out of the SqlValidatorImpl.
* If you can, make all fields of TableFunctionInfo final.
* Please restore SqlToRelTestBase.tester to final.
> UDTF like in hive
> -----------------
>
> Key: CALCITE-1581
> URL: https://issues.apache.org/jira/browse/CALCITE-1581
> Project: Calcite
> Issue Type: New Feature
> Reporter: Xiaoyong Deng
> Assignee: Sihua Zhou
> Priority: Major
> Labels: pull-request-available, udtf
> Fix For: 1.20.0
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> Support one row in and multi-column/multi-row out(one-to-many mapping), just
> like udtf in hive.
> The query would like this:
> {code}
> select
> func(c0, c1) as (f0, f1, f2)
> from table_name;
> {code}
> c0 and c1 are 'table_name' columns. f0, f1 and f2 are new generated columns.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
