[ 
https://issues.apache.org/jira/browse/CALCITE-2898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16818769#comment-16818769
 ] 

Ruben Quesada Lopez commented on CALCITE-2898:
----------------------------------------------

[~julianhyde], as you suggested, probably we should add in SemiJoin creation 
[1] the same assert that is used in SemiJoin copy:

{code:java}
assert joinInfo.isEqui();
{code}

[1] 
https://github.com/apache/calcite/blob/9538374e8fae5cec7d6f7b270850f5dfb4c1fc06/core/src/main/java/org/apache/calcite/rel/core/RelFactories.java#L408

> RelOptUtil#splitJoinCondition must consider RexFieldAccess referencing 
> RexInputRef
> ----------------------------------------------------------------------------------
>
>                 Key: CALCITE-2898
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2898
>             Project: Calcite
>          Issue Type: Bug
>    Affects Versions: 1.18.0
>            Reporter: Ruben Quesada Lopez
>            Assignee: Ruben Quesada Lopez
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> {{RelOptUtil#splitJoinCondition}} "Splits out the equi-join components of a 
> join condition, and returns what's left (remaining join filters that are not 
> equijoins)". This works fine in case of RexInputRef operands in the condition 
> (e.g. $0 = $1), but if any of the operands is a RexFieldAccess referencing a 
> RexInputRef (e.g. $0 = $1.id), then the condition will NOT be detected as an 
> equi-join and will be returned as if it were a non-equijoin. 
> This can lead to undesired consequences, e.g {{JoinInfo#of}} would return a 
> NonEquiJoinInfo object instead of an EquiJoinInfo object, which can generate 
> problems if, for example, we are creating a SemiJoin (which requires an 
> EquiJoinInfo object)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to