[
https://issues.apache.org/jira/browse/CALCITE-2453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16823643#comment-16823643
]
Chunwei Lei edited comment on CALCITE-2453 at 4/23/19 3:10 AM:
---------------------------------------------------------------
Thanks for your review, [~julianhyde]. PR is updated including:
* Add some javadoc in {{SqlParserTest}} and merge some tests.
* Use use {{assertThat}} rather than {{assertEquals}}.
I prefer to make {{checkList}} take {{List<String>}} since it can use
{{{{check(String sql, String expected)}}}} simply.
was (Author: chunwei lei):
Thanks for your review, [~julianhyde]. PR is updated including:
* Add some javadoc in {{SqlParserTest}} and merge some tests.
* Use use {{assertThat}} rather than {{assertEquals}}.
I prefer to make {{checkList}} take {{List<String> }}since it can use
{{check(String sql, String expected)}} simply.
> Enhance the SQL parser in order to optionally support semicolon at the end of
> the sql statements
> ------------------------------------------------------------------------------------------------
>
> Key: CALCITE-2453
> URL: https://issues.apache.org/jira/browse/CALCITE-2453
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Affects Versions: next
> Reporter: charbel yazbeck
> Assignee: Chunwei Lei
> Priority: Trivial
> Labels: pull-request-available
> Attachments:
> 0001-CALCITE-2453-Allowing-SQL-statements-to-optionally-e.patch
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Consists of adding [<SEMICOLON>] in Parser.jj
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
