[ 
https://issues.apache.org/jira/browse/CALCITE-2846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16825697#comment-16825697
 ] 

Danny Chan edited comment on CALCITE-2846 at 4/25/19 4:06 AM:
--------------------------------------------------------------

[~julianhyde] I have fire a PR [https://github.com/apache/calcite/pull/1181]

The main diff is:
 # Add a SqlDialectOperatorTableFactory to support fetch specific operator 
table by dialect
 # Add a annotation SqlDialect to annotate the sql functions declared in 
SqlDialectOperatorTableFactory
 # deprecate OracleSqlOperatorTable

I also think that we should not allow to change the functions dialect too easy, 
so maybe a sanity check test is needed here.


was (Author: danny0405):
[~julianhyde] I have fire a PR [https://github.com/apache/calcite/pull/1181]

The main diff is:
 # Add a SqlDialectOperatorTableFactory to support fetch specific operator 
table by dialect
 # Add a annotation SqlDialect to annotate the sql functions declared in 
SqlDialectOperatorTableFactory
 # deprecate OracleSqlOperatorTable

I also think that we should allow to change the functions dialect too easy, so 
maybe a sanity check test is needed here.

> Document Oracle-specific functions, such as NVL and LTRIM, in the SQL 
> reference
> -------------------------------------------------------------------------------
>
>                 Key: CALCITE-2846
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2846
>             Project: Calcite
>          Issue Type: Improvement
>          Components: site
>            Reporter: Julian Hyde
>            Assignee: Danny Chan
>            Priority: Major
>              Labels: documentation
>
> Document Oracle-specific functions (DECODE, NVL, LTRIM, RTRIM, SUBSTR, 
> GREATEST, LEAST) in the [SQL 
> reference|https://calcite.apache.org/docs/reference.html].
> Same goes for MySQL-specific functions (e.g. JSON_TYPE).
> I don't think we should have separate lists of Oracle-specific functions and 
> MySQL-specific functions. Because quite a few functions appear in more than 
> one place. Better, I think, to have a concise annotation against each 
> function which tables it occurs in.
> The current list of tables is standard, oracle, spatial, mysql. Perhaps also 
> indicate whether a function is an extension to the SQL standard but still 
> occurs in Calcite's default table.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to