[
https://issues.apache.org/jira/browse/CALCITE-3016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16826346#comment-16826346
]
Julian Hyde commented on CALCITE-3016:
--------------------------------------
I reviewed the PR; I made some small comments in the PR, but the major one is
use of the word "Dialect". This thing is orthogonal to dlalect (you could
imagine a connection that uses Calcite's dialect of SQL but wants the MySQL
function set). What is a good word? "Flavor" is the best I can come up with.
Any other ideas?
Note that the "flavor" names are used in the "fun" JDBC connect string
parameter; see
https://calcite.apache.org/apidocs/org/apache/calcite/config/CalciteConnectionProperty.html#FUN.
We should definitely not have a new class called "SqlDialect". There is already
a "SqlDialect" class in a different package.
> Reorganize the operator tables
> ------------------------------
>
> Key: CALCITE-3016
> URL: https://issues.apache.org/jira/browse/CALCITE-3016
> Project: Calcite
> Issue Type: Improvement
> Affects Versions: 1.19.0, 1.20.0
> Reporter: Danny Chan
> Assignee: Danny Chan
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Reorganize the operator tables
> # Make a CommonOperatorTable for operators that belong to multiple dialect
> # create a dialect to operator table mapping cache for used dialect
> # annotation the function with specific annotation for operators in
> CommonOperatorTable
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
