[ 
https://issues.apache.org/jira/browse/CALCITE-3029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16828032#comment-16828032
 ] 

Hongze Zhang commented on CALCITE-3029:
---------------------------------------

Thanks [~zabetak].

Regarding the issue, I am more or less sure that the problem didn't exist 
before CALCITE-2464. I run the same test case[1] of inserting nullable values 
under commit 
[8eb852|https://github.com/apache/calcite/commit/8eb852039db04c132ae7a99943495f87cf39dfd2]
 (the commit right behind 2464 fix) and it passed.

[1] 
[https://github.com/apache/calcite/pull/1187/files#diff-fcafae074e093e34d065f7f5a49f5124R712]

> Java-oriented field type is wrongly forced to be NOT NULL after being 
> converted to SQL-oriented
> -----------------------------------------------------------------------------------------------
>
>                 Key: CALCITE-3029
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3029
>             Project: Calcite
>          Issue Type: Bug
>    Affects Versions: 1.19.0
>            Reporter: Hongze Zhang
>            Assignee: Hongze Zhang
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.20.0
>
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> A Java-oriented field type loses its nullable constraint after calling method 
> {{org.apache.calcite.jdbc.JavaTypeFactoryImpl#toSql(org.apache.calcite.rel.type.RelDataType)}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to