[ 
https://issues.apache.org/jira/browse/CALCITE-3040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16830877#comment-16830877
 ] 

Stamatis Zampetakis commented on CALCITE-3040:
----------------------------------------------

I assume this change breaks only unit tests which expect the message in a 
specific place. I've notice this when testing against Calcite for the vote of 
Avatica 1.14.0 but I it didn't seem to me like a big issue since I considered 
that it is easy to rewrite the tests and check for the detailed message in 
another place (getCause). I think it was a mistake from our side that we didn't 
specify this behavior in the release note but the change overall seemed 
meaningful when I checked the PR.

[~apilloud] this is a regression but it is supposed to improve the exception 
messages. Wouldn't you consider modifying the tests on your side?

> Avatica drops exception messages starting in 1.14.0
> ---------------------------------------------------
>
>                 Key: CALCITE-3040
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3040
>             Project: Calcite
>          Issue Type: Bug
>          Components: avatica
>    Affects Versions: avatica-1.14.0
>         Environment: Beam 2.13.0-SNAPSHOT
>  Avatica 1.14.0
> [https://github.com/apache/beam/pull/8437]
>            Reporter: Andrew Pilloud
>            Priority: Major
>             Fix For: avatica-1.15.0
>
>
> With Avatica 1.13.0 we get detailed exceptions:
> {code:java}
> Welcome to Beam SQL 2.13.0-SNAPSHOT (based on sqlline version 1.4.0)
> 0: BeamSQL> create external table testing (a int) type text location 
> '/tmp/test';
> No rows affected (0.246 seconds)
> 0: BeamSQL> set runner = bogus;
> No rows affected (0.009 seconds)
> 0: BeamSQL> select * from testing;
> Error: Error while executing SQL "select * from testing": Unknown 'runner' 
> specified 'bogus', supported pipeline runners [DirectRunner] (state=,code=0)
> 0: BeamSQL>
> {code}
> In 1.14.0 the details of the failure are missing:
> {code:java}
> Welcome to Beam SQL 2.13.0-SNAPSHOT (based on sqlline version 1.4.0)
> 0: BeamSQL> create external table testing (a int) type text location 
> '/tmp/test';
> No rows affected (0.244 seconds)
> 0: BeamSQL> set runner = bogus;
> No rows affected (0.009 seconds)
> 0: BeamSQL> select * from testing;
> Error: Error while executing SQL "select * from testing" (state=,code=0)
> 0: BeamSQL>
> {code}
> This appears to be caused by CALCITE-2845



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to