[ 
https://issues.apache.org/jira/browse/CALCITE-3062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16837762#comment-16837762
 ] 

Laurent Goujon commented on CALCITE-3062:
-----------------------------------------

I didn't observe the behavior you mention. Based on my research, only two 
classes access the field (VolcanoPlanner and RelSubset) and only VolcanoPlanner 
actually reads the content of the map, at the end of {{findBestExp}} method 
call, only in debug mode, to display the provenance of each node of the best 
plan... Changing the behavior of the planner to not populate the map doesn't 
impact any of the Calcite tests too.

> Do not populate provenanceMap if not used
> -----------------------------------------
>
>                 Key: CALCITE-3062
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3062
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>            Reporter: Laurent Goujon
>            Assignee: Laurent Goujon
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> {{VolcanoPlanner}}'s field {{provenanceMap}} tracks the provenance of each 
> node being added to the planner, but the information is only used when the 
> log level of the planner of the debug, so when planner is not running in 
> debug mode, this data goes to waste and used memory unnecessary.
> The planner should be changed so that the information is only captured if 
> used later.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to