[ https://issues.apache.org/jira/browse/CALCITE-3065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16840933#comment-16840933 ]
Jiatao Tao edited comment on CALCITE-3065 at 5/16/19 2:39 AM: -------------------------------------------------------------- Hi [~danny0405] Thanks, it answers my doubts. But I got this literal in RexVisitor, I think it is after validating? Hi [~julianhyde] By the way, I still think we can do "Primitive.box(clazz)" inside *SqlLiteral#**getValueAs,* isn't this more reasonable? ** We expected all clazz to be boxed, use "Primitive.box" to insure this. {code:java} public <T> T getValueAs(Class<T> clazz) { clazz = Primitive.box(clazz); ... }{code} Hope to hear your opinion, really appreciate. was (Author: aron.tao): [~danny0405] Thanks, it answers my doubts. But I got this literal in RexVisitor, I think it is after validating? [~julianhyde] By the way, I still think we can do "Primitive.box(clazz)" inside *SqlLiteral#**getValueAs,* isn't this more reasonable? ** We expected all clazz to be boxed, use "Primitive.box" to insure this. Hope to hear your opinion, really appreciate. > RexLiteral#getValueAs should consider primitive type > ---------------------------------------------------- > > Key: CALCITE-3065 > URL: https://issues.apache.org/jira/browse/CALCITE-3065 > Project: Calcite > Issue Type: Improvement > Components: core > Reporter: Jiatao Tao > Priority: Major > Labels: pull-request-available > Attachments: image-2019-05-13-12-04-36-365.png > > Time Spent: 10m > Remaining Estimate: 0h > > !image-2019-05-13-12-04-36-365.png! -- This message was sent by Atlassian JIRA (v7.6.3#76005)