[
https://issues.apache.org/jira/browse/CALCITE-3050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16845864#comment-16845864
]
Ruben Quesada Lopez commented on CALCITE-3050:
----------------------------------------------
[~julianhyde], could it be possible that this change had introduced some issues?
In my local environment (Windows) I now get the following errors when running
the tests:
{code}
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR] SqlParserTest.testConfigureFromDialect:8738->checkDialect:8768
Expected: is "SELECT \"UNQUOTEDCOLUMN\"\nFROM \"doubleQuotedTable\""
but: was "SELECT \"UNQUOTEDCOLUMN\"\r\nFROM \"doubleQuotedTable\""
[ERROR]
SqlUnParserTest>SqlParserTest.testConfigureFromDialect:8738->SqlParserTest.checkDialect:8768
Expected: is "SELECT \"UNQUOTEDCOLUMN\"\nFROM \"doubleQuotedTable\""
but: was "SELECT \"UNQUOTEDCOLUMN\"\r\nFROM \"doubleQuotedTable\""
[ERROR]
ExtensionSqlParserTest>SqlParserTest.testConfigureFromDialect:8738->SqlParserTest.checkDialect:8768
Expected: is "SELECT \"UNQUOTEDCOLUMN\"\nFROM \"doubleQuotedTable\""
but: was "SELECT \"UNQUOTEDCOLUMN\"\r\nFROM \"doubleQuotedTable\""
[INFO]
[ERROR] Tests run: 5203, Failures: 3, Errors: 0, Skipped: 112
{code}
Which seems to be the same issue that we have right now with the continuous
integration tests of some open PRs, like [this
one|https://github.com/apache/calcite/pull/1183] or [this
one|https://github.com/apache/calcite/pull/1163].
> Integrate SqlDialect and SqlParser.Config
> -----------------------------------------
>
> Key: CALCITE-3050
> URL: https://issues.apache.org/jira/browse/CALCITE-3050
> Project: Calcite
> Issue Type: Bug
> Reporter: Julian Hyde
> Assignee: Julian Hyde
> Priority: Major
> Fix For: 1.20.0
>
>
> {{SqlDialect}} is used by the JDBC adapter to generate SQL in the target
> dialect of a data source. {{SqlParser.Config}} is used to set what the parser
> should allow for SQL statements sent to Calcite. But they both are a
> representation of "dialect". And they come together when we want to use a
> Babel parser to understand SQL statements that are meant for a data source.
> So it makes sense to integrate them, somehow. We could add a method
> {code}void SqlParser.ConfigBuilder.setFrom(SqlDialect dialect){code} or do it
> from the other end, {code}SqlDialect.configureParser(SqlParser.ConfigBuilder
> configBuilder){code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
