[
https://issues.apache.org/jira/browse/CALCITE-2460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16851176#comment-16851176
]
Julian Hyde commented on CALCITE-2460:
--------------------------------------
Reviewing PR 800:
* You don't need to check for null. Calcite will not call your function if the
string is null. Remove the 'if'.
* Change the JIRA case tittle and the commit message to describe what the
end-user cares about: "Implement TO_BASE64 and FROM_BASE64 functions". (Think
about what you would like to appear in the release notes.) The fact that you
have added methods to SqlFunctions is just an implementation detail.
* TO_BASE64 takes a BINARY or VARBINARY, not a VARCHAR, as argument.
* FROM_BASE64 returns a VARBINARY, not a VARCHAR.
cc [~sereda]
> Add implementation of To_Base64 to SqlFunctions
> -----------------------------------------------
>
> Key: CALCITE-2460
> URL: https://issues.apache.org/jira/browse/CALCITE-2460
> Project: Calcite
> Issue Type: Improvement
> Reporter: vinoyang
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 2h
> Remaining Estimate: 0h
>
> refer to mysql TO_BASE64 function :
> [https://dev.mysql.com/doc/refman/5.6/en/string-functions.html#function_to-base64]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
