[
https://issues.apache.org/jira/browse/CALCITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16853085#comment-16853085
]
Ruben Quesada Lopez edited comment on CALCITE-2969 at 5/31/19 2:44 PM:
-----------------------------------------------------------------------
I think there's one small detail that we forgot in this ticket: the file
{{algebra.md}} still references the deprecated {{SemiJoin}} when describing the
{{semiJoin(expr)}} method:
{code}
...
| `semiJoin(expr)` | Creates a [SemiJoin]({{ site.apiRoot
}}/org/apache/calcite/rel/core/SemiJoin.html) of the two most recent relational
expressions.
...
{code}
This is no longer correct, since this method creates now a {{Join}} with
{{type=SEMI}}.
was (Author: rubenql):
I think there's one small detail that we forgot in this ticket: the file
{{algebra.md}} still references the deprecated {{SemiJoin}} when describing the
{{semiJoin(expr)}} method:
{code}
...
| `semiJoin(expr)` | Creates a [SemiJoin]({{ site.apiRoot
}}/org/apache/calcite/rel/core/SemiJoin.html) of the two most recent relational
expressions.
{code}
This is no longer correct, since this method creates now a {{Join}} with
{{type=SEMI}}.
> Improve design of join-like relational expressions
> --------------------------------------------------
>
> Key: CALCITE-2969
> URL: https://issues.apache.org/jira/browse/CALCITE-2969
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.19.0
> Reporter: Stamatis Zampetakis
> Assignee: Danny Chan
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.20.0
>
> Time Spent: 31h
> Remaining Estimate: 0h
>
> The existing join-like (Join, SemiJoin, Correlate, etc.) logical and physical
> relational expressions have a few design issues which make some parts of the
> codebase complicated and difficult to understand.
> The goal of this ticket is to improve the design of the respective
> expressions based on the discussion in the dev list (see thread [Join,
> SemiJoin,
> Correlate|https://mail-archives.apache.org/mod_mbox/calcite-dev/201903.mbox/%3C8EEA04A0-4A77-4283-BD20-B019E19AE126%40apache.org%3E]).
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
