[
https://issues.apache.org/jira/browse/CALCITE-3119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16861217#comment-16861217
]
Julian Hyde edited comment on CALCITE-3119 at 6/11/19 5:07 PM:
---------------------------------------------------------------
* Remove, don't deprecate, unused methods in {{EnumerableDefaults.java}}. That
class is not a public API.
* The method {{toLinq4jCorrelateJoinType}} was only just created, since 1.19.
Remove it.
* I considered just removing {{enum CorrelateJoinType}}, but instead I think we
should keep it for one minor release; I think we should mark it 'deprecated to
be removed before 1.21'.
was (Author: julianhyde):
Remove, don't deprecate, unused methods in EnumerableDefaults.java. That class
is not public.
> Deprecate Linq4j CorrelateJoinType (in favor of JoinType)
> ---------------------------------------------------------
>
> Key: CALCITE-3119
> URL: https://issues.apache.org/jira/browse/CALCITE-3119
> Project: Calcite
> Issue Type: Task
> Reporter: Ruben Quesada Lopez
> Assignee: Ruben Quesada Lopez
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.20.0
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> CALCITE-2968 introduced in Linq4j a new (more general) enum JoinType. As a
> result, we have right now two enums for (almost) the same purpose:
> CorrelateJoinType (used for Correlation, thus defining only INNER, LEFT,
> SEMI, ANTI) and the new JoinType (can be used for any purpose, defining all
> types of join, mirroring core's JoinRelType).
> The idea is to flag CorrelateJoinType as deprecated, and replace all its
> usages by JoinType.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
