[ 
https://issues.apache.org/jira/browse/CALCITE-3119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16863021#comment-16863021
 ] 

Ruben Quesada Lopez commented on CALCITE-3119:
----------------------------------------------

[~michaelmior], in my opinion, yes.

> Deprecate Linq4j CorrelateJoinType (in favor of JoinType)
> ---------------------------------------------------------
>
>                 Key: CALCITE-3119
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3119
>             Project: Calcite
>          Issue Type: Task
>            Reporter: Ruben Quesada Lopez
>            Assignee: Ruben Quesada Lopez
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.20.0
>
>          Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> CALCITE-2968 introduced in Linq4j a new (more general) enum JoinType. As a 
> result, we have right now two enums for (almost) the same purpose: 
> CorrelateJoinType (used for Correlation, thus defining only INNER, LEFT, 
> SEMI, ANTI) and the new JoinType (can be used for any purpose, defining all 
> types of join, mirroring core's JoinRelType).
> The idea is to flag CorrelateJoinType as deprecated, and replace all its 
> usages by JoinType.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to