[
https://issues.apache.org/jira/browse/CALCITE-3146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16872609#comment-16872609
]
Haisheng Yuan commented on CALCITE-3146:
----------------------------------------
Agree with what Julian said. +1 on the patch.
> Support the detection of nested aggregations for JdbcAggregate in
> SqlImplementor.
> ---------------------------------------------------------------------------------
>
> Key: CALCITE-3146
> URL: https://issues.apache.org/jira/browse/CALCITE-3146
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.19.0
> Reporter: TANG Wen-hui
> Assignee: TANG Wen-hui
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The detection of nested aggregations in SqlImplementor.java is only for
> LogicalAggregate:
>
> {code:java}
> if (rel instanceof LogicalAggregate
> && !dialect.supportsNestedAggregations()
> && hasNestedAggregations((LogicalAggregate) rel)) {
> needNew = true;
> }
> {code}
> It should also support other sub-class of Aggregate such as JdbcAggregate .
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
