[ https://issues.apache.org/jira/browse/CALCITE-3166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16876677#comment-16876677 ]
Danny Chan commented on CALCITE-3166: ------------------------------------- Thanks [~julianhyde], i'm ok with this Context unwrap, cause it seems like a code refactoring. > Make RelBuilder configurable > ---------------------------- > > Key: CALCITE-3166 > URL: https://issues.apache.org/jira/browse/CALCITE-3166 > Project: Calcite > Issue Type: Bug > Reporter: Julian Hyde > Assignee: Julian Hyde > Priority: Major > Labels: pull-request-available > Fix For: 1.21.0 > > > Make {{RelBuilder}} configurable, so that particular optimizations can easily > be turned off. > I propose to add a class {{RelBuilder.Config}}, which is immutable and has a > public final field for each configuration property; also a class > {{RelBuilder.ConfigBuilder}} to create a config. > {{RelBuilder.create(FrameworkConfig frameworkConfig)}} will get a config by > calling {{frameworkConfig.getContext().unwrap(RelBuilder.Config.class)}}. -- This message was sent by Atlassian JIRA (v7.6.3#76005)