[ https://issues.apache.org/jira/browse/CALCITE-3182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
jin xing updated CALCITE-3182: ------------------------------ Description: In current code, before matching query with materialized-view, unused fields of query is trimed but materialized-view is not. Thus below simple SQL fails to be matched though query and materialized- view are exactly the same ``` @Test public void testMaterializationAfterTrimingOfUnusedFields() { String sql = "select \"y\".\"deptno\", \"y\".\"name\", \"x\".\"sum_salary\"\n" + "from\n" + " (select \"deptno\", sum(\"salary\") \"sum_salary\" from \"emps\" group by \"deptno\") \"x\"\n" + " join\n" + " \"depts\" \"y\"\n" + " on \"x\".\"deptno\"=\"y\".\"deptno\"\n"; checkMaterialize(sql, sql); } ``` Checking {{CalciteMaterializer}} https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/prepare/CalciteMaterializer.java#L83 , I think the code intends to do the trimming, but didn't call the method. Since query is trimed for unused fields in anyway https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/prepare/CalcitePrepareImpl.java#L995 , thus I think there's no n ecessity to keep the materialized-view un-trimmed was: In current code, before matching query with materialized-view, unused fields of query is trimed but materialized-view is not. Thus below simple SQL fails to be matched though query and materialized- view are exactly the same ``` @Test public void testMaterializationAfterTrimingOfUnusedFields() { String sql = "select \"y\".\"deptno\", \"y\".\"name\", \"x\".\"sum_salary\"\n" + "from\n" + " (select \"deptno\", sum(\"salary\") \"sum_salary\" from \"emps\" group by \"deptno\") \"x\"\n" + " join\n" + " \"depts\" \"y\"\n" + " on \"x\".\"deptno\"=\"y\".\"deptno\"\n"; checkMaterialize(sql, sql); } ``` Checking \{{CalciteMaterializer}} https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/prepare/CalciteMaterializer.java#L83 , I think the code intends to do the trimming, but didn't call the method. Since query is trimed for unused fields in anyway https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/prepare/CalcitePrepareImpl.java#L995 , thus I think there's no n ecessity to keep the materialized-view un-trimmed > Trim unused fields for plan of materialized-view before matching. > ----------------------------------------------------------------- > > Key: CALCITE-3182 > URL: https://issues.apache.org/jira/browse/CALCITE-3182 > Project: Calcite > Issue Type: Improvement > Reporter: jin xing > Priority: Major > > In current code, before matching query with materialized-view, unused fields > of query is trimed but materialized-view is not. Thus below simple SQL fails > to be matched though query and materialized- > view are exactly the same > ``` > @Test public void testMaterializationAfterTrimingOfUnusedFields() { > String sql = > "select \"y\".\"deptno\", \"y\".\"name\", \"x\".\"sum_salary\"\n" + > "from\n" + > " (select \"deptno\", sum(\"salary\") \"sum_salary\" from \"emps\" > group by \"deptno\") \"x\"\n" + > " join\n" + > " \"depts\" \"y\"\n" + > " on \"x\".\"deptno\"=\"y\".\"deptno\"\n"; > checkMaterialize(sql, sql); > } > ``` > Checking {{CalciteMaterializer}} > https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/prepare/CalciteMaterializer.java#L83 > , I think the code intends to do the trimming, but didn't call the method. > Since query is trimed for unused fields in anyway > https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/prepare/CalcitePrepareImpl.java#L995 > , thus I think there's no n > ecessity to keep the materialized-view un-trimmed -- This message was sent by Atlassian JIRA (v7.6.3#76005)