[
https://issues.apache.org/jira/browse/CALCITE-3197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16885816#comment-16885816
]
jin xing commented on CALCITE-3197:
-----------------------------------
[~julianhyde]
THX a lot for comment.
“The idea that a representation knows what it really should be seems very
wrong” -- This really helps me to get clear about the design.
I will refine my change by your comment.
> Convert data of Timestamp/Time/Date as original form when enumerating from
> ArrayTable
> -------------------------------------------------------------------------------------
>
> Key: CALCITE-3197
> URL: https://issues.apache.org/jira/browse/CALCITE-3197
> Project: Calcite
> Issue Type: Bug
> Components: core
> Reporter: jin xing
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In current implementation ColumnLoader, data of
> {{Rep.JAVA_SQL_TIMESTAMP/Rep.JAVA_SQL_TIME/Rep.JAVA_SQL_DATE}} are converted
> as numeric during loading.
> https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/adapter/clone/ColumnLoader.java#L234
> But current code seems forgot to revert the data back to original form when
> enumerating.
> As a result, below test is failing now
> {code:java}
> // MaterializationTest.java
> @Test public void testTimestampType() {
> String sql = "select \"eventid\", \"ts\"\n"
> + "from \"events\"\n"
> + "where \"eventid\" > 5";
> checkMaterialize(sql, sql);
> }{code}
> For type of {{Rep.JAVA_SQL_TIMESTAMP/Rep.JAVA_SQL_TIME/Rep.JAVA_SQL_DATE}},
> cursor acesses by {{TimestampAccessor/TimeAccessor/DateAccessor}}, which
> expect column value as {{Timestamp/Time/Date}}.
> It make sense to 'unwrap' the data as original form when enumerating from
> {{ArrayTable}}.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
