[
https://issues.apache.org/jira/browse/CALCITE-3200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16887537#comment-16887537
]
pingle wang commented on CALCITE-3200:
--------------------------------------
[~zabetak] I just read the issue and mailing list，My PR and the previous PR and
issue have these differences.
1. I implemented the
[[SqlTypeName|https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/sql/type/SqlTypeName.java#L230]|[https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/sql/type/SqlTypeName.java#L230]]
TODO
{code:java}
// TODO: additional types not yet supported. See ExtraSqlTypes.
// .put(Types.LONGVARCHAR, Longvarchar){code}
fix like:
{code:java}
.put(Types.LONGVARCHAR, TEXT){code}
2. The database uses the TEXT type, certainly not LONGVARCHAR. Also not the use
of varchar mentioned in the mail and then take the alias, because if we know
the maximum length, it is suitable to use varchar, otherwise it is suitable to
use TEXT.
3. [~mgelbana] said the error in the mail, I have not met yet.
thanks
> Add TEXT Data Type
> ------------------
>
> Key: CALCITE-3200
> URL: https://issues.apache.org/jira/browse/CALCITE-3200
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.20.0
> Reporter: pingle wang
> Priority: Major
> Labels: pull-request-available
> Fix For: next
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> 1. SQL Server, Mysql, Oracle support TEXT data type.
> 2. java.sql.Types LONGVARCHAR is TEXT.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
