[
https://issues.apache.org/jira/browse/CALCITE-3209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16891892#comment-16891892
]
Julian Hyde edited comment on CALCITE-3209 at 7/24/19 2:26 PM:
---------------------------------------------------------------
You’ve described the solution, not the problem. The bug and commit header
should describe the problem, namely that setInput throws. Otherwise, looks
good.
was (Author: julianhyde):
You’ve described the solution, not the problem. The bug and commit header
should describe the problem, namely that setInput throws.
> Store inputs of MutableMultiRel by ArrayList rather than ImmutableList
> ----------------------------------------------------------------------
>
> Key: CALCITE-3209
> URL: https://issues.apache.org/jira/browse/CALCITE-3209
> Project: Calcite
> Issue Type: Bug
> Components: core
> Reporter: jin xing
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When digging code of materialization matching. I found the current
> implementation of {{MutableMultiRel::}}{{inputs}} is by an {{ImmutableList}},
> thus impossible to be changed by
>
> [https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/rel/mutable/MutableMultiRel.java#L42]
> {code:java}
> @Override public void setInput(int ordinalInParent, MutableRel input)
> {code}
> Seems a mistake.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
