[
https://issues.apache.org/jira/browse/CALCITE-3192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16895446#comment-16895446
]
Julian Hyde commented on CALCITE-3192:
--------------------------------------
Can you change "weaks" to "weakens" in the JIRA and commit titles. "Weaks" is
not a verb.
Can you document or otherwise clean up {{isSupportedAsOrPredicate}}? How did
you derive the list of which predicates are supported? What is an "or
predicate" anyway?
This double (or triple) negative is difficult to read:
{code}
if (!(Predicate.of(t) == null || !isSupportedAsOrPredicate(t))) {
continue;
}
{code}
> Simplify OR incorrectly weaks condition
> ---------------------------------------
>
> Key: CALCITE-3192
> URL: https://issues.apache.org/jira/browse/CALCITE-3192
> Project: Calcite
> Issue Type: Bug
> Reporter: Jess Balint
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.21.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> RexSimplify is transforming
> * {{OR(AND(>(999, $8), =($2, 'Franklin')), <(100, $8))}}
> * to {{OR(=($2, 'Franklin'), <(100, $8))}}
> the predicates are accumulated in {{simplifyOrTerms()}} but not discarded
> when iterating the second time
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
