[
https://issues.apache.org/jira/browse/CALCITE-3204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897564#comment-16897564
]
Julian Hyde commented on CALCITE-3204:
--------------------------------------
JsonEnumerator no longer matches its description "Enumerator that reads from a
JSON file.", because it now works on object arrays, and does not depend on
Jackson. And I see you have moved the Jackson-specific logic into JsonTable.
I can see that JsonEnumerator has a useful purpose, but you need to rename it
and revise the doc.
Also I don't think that Jackson-parsing logic should be in JsonTable. Tables
are about metadata (prepare time) not about the actual parsing (runtime).
Can you revise, please.
> Implement jps command for OS adapter
> ------------------------------------
>
> Key: CALCITE-3204
> URL: https://issues.apache.org/jira/browse/CALCITE-3204
> Project: Calcite
> Issue Type: New Feature
> Reporter: Forward Xu
> Assignee: Julian Hyde
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Implement jps command for OS adapter
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
