[
https://issues.apache.org/jira/browse/CALCITE-3215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16899132#comment-16899132
]
Julian Hyde commented on CALCITE-3215:
--------------------------------------
[~kgyrtkirk] I saw you made some remarks on
https://github.com/apache/calcite/pull/1339 about the number of iterations of
fuzzy test. Can we move the discussion over to this JIRA case, since PRs tend
to go stale after they are merged.
I would like to have an option to run manually fuzzy test for more iterations
occasionally (e.g. before merging a signficant change to the simplifier), and
to know that those iterations previously succeeded. Is this possible?
> Simplification may have not fully simplified IS NOT NULL expressions
> --------------------------------------------------------------------
>
> Key: CALCITE-3215
> URL: https://issues.apache.org/jira/browse/CALCITE-3215
> Project: Calcite
> Issue Type: Bug
> Reporter: Zoltan Haindrich
> Assignee: Zoltan Haindrich
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.21.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> CALCITE-2929 have added a safety check to avoid simplifying problematic cases.
> The safety check apparently misses some kinds, for example: {{UNARY_PLUS}}
> {code}
> @Test public void testIsNullSimplificationWithUnaryPlus() {
> RexNode expr =
> isNotNull(coalesce(unaryPlus(vInt(1)), vIntNotNull(0)));
> RexNode s = simplify.simplifyUnknownAs(expr, RexUnknownAs.UNKNOWN);
> assertThat(expr.isAlwaysTrue(), is(true));
> assertThat(s, is(trueLiteral));
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
