[ 
https://issues.apache.org/jira/browse/CALCITE-3089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16904183#comment-16904183
 ] 

Julian Hyde commented on CALCITE-3089:
--------------------------------------

Today, given {{join}} of type {{Join}}, you would write
{code}
if (join instanceof EquiJoin) ...
{code}
but after this change you would write
{code}
if (join.analyzeCondition().isEqui()) ...
{code}

The latter code already works, but would become the only way. Is my example 
correct? If not, please correct it.

> Deprecate EquiJoin
> ------------------
>
>                 Key: CALCITE-3089
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3089
>             Project: Calcite
>          Issue Type: Improvement
>            Reporter: Haisheng Yuan
>            Assignee: Haisheng Yuan
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.21.0
>
>          Time Spent: 3h 40m
>  Remaining Estimate: 0h
>
> EquiJoin should be replaced by Join with equiConds and nonEquiConds (empty if 
> it doesn't have).
> EquiJoin will not have any subclasses. EnumerableHashJoin and 
> EnumerableMergeJoin, SemiJoin should extend Join directly.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to