[
https://issues.apache.org/jira/browse/CALCITE-3167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906823#comment-16906823
]
jin xing commented on CALCITE-3167:
-----------------------------------
[~julianhyde]
Gentle ping ~
In current change, I made equals/hashCode methods final in {{AbstractRelNode}}
and passed all the tests.
And I'm not sure if [~amargoor] has some other ideas or comments on this one.
Could you please leave more comments? and it's great if there's chance this
patch can be merged.
> Remove overriding equals and hashCode methods in EnumerableTableScan
> --------------------------------------------------------------------
>
> Key: CALCITE-3167
> URL: https://issues.apache.org/jira/browse/CALCITE-3167
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.19.0
> Reporter: jin xing
> Assignee: jin xing
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> In current code of {{EnumerableTableScan}}, methods of equals and hashCode
> are overridden for matching of {{EnumerableTableScan}}s.
> While after optimizing with the same HEP planner, {{EnumerableTableScan}}s
> from two plans but with the same digest will the share the same Java object.
> See
> [RelOptMaterializations|https://github.com/apache/calcite/blob/adf4cc4dc5cdb9f5e49c85d10f46a2fdcd831ccf/core/src/main/java/org/apache/calcite/plan/RelOptMaterializations.java#L192].
> I think it's ok to remove the redundant overriding methods in
> {{EnumerableTableScan}}.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
