[
https://issues.apache.org/jira/browse/CALCITE-3280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16913729#comment-16913729
]
Julian Hyde commented on CALCITE-3280:
--------------------------------------
A couple of review comments:
* Remove the check for null values at the top of {{regexpReplace}}. The
container will do that.
* Can you use {{StringBuilder}} rather than {{StringBuffer}}? It is more
efficient, because it does not use locking.
* I don't mind whether we support other variants of REGEXP_REPLACE, but in the
javadoc of the REGEXP_REPLACE member please state which variant(s) you support.
* Typo: "testRexexpReplaceFunc"
> Cannot parse query REGEXP_REPLACE in Redshift
> ---------------------------------------------
>
> Key: CALCITE-3280
> URL: https://issues.apache.org/jira/browse/CALCITE-3280
> Project: Calcite
> Issue Type: Improvement
> Reporter: Ryan Fu
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> REGEXP_REPLACE error:
> {code:}
> No match found for function signature REGEXP_REPLACE(<CHARACTER>,
> <CHARACTER>, <CHARACTER>){code}
>
> Example query:
> {code:sql}
> SELECT * , MD5(TRIM(BOTH ' ' FROM REGEXP_REPLACE(LOWER(name),
> '([[:space:]]|,)+([iInNcC]|[lLcC]).*$', ''))) AS company_id FROM
> public.account {code}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
