[
https://issues.apache.org/jira/browse/CALCITE-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16916569#comment-16916569
]
Stamatis Zampetakis commented on CALCITE-1581:
----------------------------------------------
I was ready to merge this to master but I noticed that it creates various
javacc warnings (see below). What do you think [~pzw2018], is it easy to
resolve them?
{noformat}
Java Compiler Compiler Version 4.0 (Parser Generator)
(type "javacc" with no arguments for help)
Reading from file
/home/zabetak/Workspaces/Apache/Calcite/core/target/generated-sources/fmpp/javacc/Parser.jj
. . .
Note: UNICODE_INPUT option is specified. Please make sure you create the
parser/lexer using a Reader with the correct character encoding.
Warning: Choice conflict in [...] construct at line 4063, column 16.
Expansion nested within construct and expansion following construct
have common prefixes, one of which is: "("
Consider using a lookahead of 2 or more for nested expansion.
Warning: Choice conflict in [...] construct at line 4072, column 17.
Expansion nested within construct and expansion following construct
have common prefixes, one of which is: "("
Consider using a lookahead of 2 or more for nested expansion.
Warning: Choice conflict in [...] construct at line 4075, column 15.
Expansion nested within construct and expansion following construct
have common prefixes, one of which is: "("
Consider using a lookahead of 2 or more for nested expansion.
Warning: Choice conflict in [...] construct at line 4083, column 17.
Expansion nested within construct and expansion following construct
have common prefixes, one of which is: "("
Consider using a lookahead of 2 or more for nested expansion.
Warning: Choice conflict in [...] construct at line 4088, column 16.
Expansion nested within construct and expansion following construct
have common prefixes, one of which is: "("
Consider using a lookahead of 2 or more for nested expansion.
Warning: Choice conflict in [...] construct at line 4094, column 17.
Expansion nested within construct and expansion following construct
have common prefixes, one of which is: "("
Consider using a lookahead of 2 or more for nested expansion.
Warning: Choice conflict in [...] construct at line 4099, column 18.
Expansion nested within construct and expansion following construct
have common prefixes, one of which is: "("
Consider using a lookahead of 2 or more for nested expansion.
Warning: Choice conflict in [...] construct at line 4103, column 17.
Expansion nested within construct and expansion following construct
have common prefixes, one of which is: "("
Consider using a lookahead of 2 or more for nested expansion.
Warning: Choice conflict in [...] construct at line 4109, column 9.
Expansion nested within construct and expansion following construct
have common prefixes, one of which is: "("
Consider using a lookahead of 2 or more for nested expansion.
{noformat}
I have also a minor comment regarding the commit message. The details are not
very informative especially since the commit is squashed so I was ready to
remove most of them. In the future if the commit is squashed try to include
only those details that are significant (for instance 'fix format' etc., does
not need to be present). If the commit is not squashed try to have a commit
message that is self contained to facilitate the person who is doing the
squash.
> UDTF like in hive
> -----------------
>
> Key: CALCITE-1581
> URL: https://issues.apache.org/jira/browse/CALCITE-1581
> Project: Calcite
> Issue Type: New Feature
> Reporter: Xiaoyong Deng
> Assignee: pengzhiwei
> Priority: Major
> Labels: pull-request-available, udtf
> Fix For: 1.21.0
>
> Time Spent: 8h 10m
> Remaining Estimate: 0h
>
> Support one row in and multi-column/multi-row out(one-to-many mapping), just
> like udtf in hive.
> The query would like this:
> {code}
> select
> func(c0, c1) as (f0, f1, f2)
> from table_name;
> {code}
> c0 and c1 are 'table_name' columns. f0, f1 and f2 are new generated columns.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
