[ 
https://issues.apache.org/jira/browse/CALCITE-3334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16925666#comment-16925666
 ] 

jin xing edited comment on CALCITE-3334 at 9/9/19 1:30 PM:
-----------------------------------------------------------

I have a commit to illustrate the idea shown in the design doc:
[https://github.com/jinxing64/calcite/commit/dd8d7f15faa852641e19f42c51afade5bf7728f2]

In the commit, I replaced existing substitution-based rules by new defined 
rules and passed all tests. Also I added more test cases which can not be 
supported by original matching rules.

If this idea proposed is interested, I can split the this work into several 
issues and submit implementations


was (Author: jinxing6...@126.com):
I have a commit to illustrate the idea shown in the design doc:
[https://github.com/jinxing64/calcite/commit/dd8d7f15faa852641e19f42c51afade5bf7728f2]

In the commit, I replaced existing substitution-based rules by new defined 
rules and passed all tests. Also I added more test cases which can not be 
supported by original matching rules

If this idea proposed is interested, I can split the this work into several 
issues and submit implementations

> Refinement for Substitution-Based MV Matching
> ---------------------------------------------
>
>                 Key: CALCITE-3334
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3334
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>            Reporter: jin xing
>            Priority: Major
>
> The approach of substitution-based MV matching is an effective way for its 
> simplicity and extensibility. 
> This JIRA proposes to refine existing implementation by several points:
>  # Canonicalize before MV matching -- by such canonicalization we can 
> significantly simplify the algebra tree and lower the difficulty for 
> materialization matching.
>  # Separate matching rules into two categories and enumerate common matching 
> patterns which need to be covered by rules.
> Please check the design doc: [Design 
> Doc|https://docs.google.com/document/d/1JpwGNFE3hw3yXb7W3-95-jXKClZC5UFPKbuhgYDuEu4/edit#]



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Reply via email to