[
https://issues.apache.org/jira/browse/CALCITE-3331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Danny Chan resolved CALCITE-3331.
---------------------------------
Resolution: Fixed
Thanks [~zabetak] and fixed in
[d3c7183|https://github.com/apache/calcite/commit/d3c718328d4c83fb24007c8349b31b420dddd187]
!
> Support implicit type cast for operators that use single operand family
> checker
> -------------------------------------------------------------------------------
>
> Key: CALCITE-3331
> URL: https://issues.apache.org/jira/browse/CALCITE-3331
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.20.0
> Reporter: Danny Chan
> Assignee: Danny Chan
> Priority: Minor
> Labels: pull-request-available
> Fix For: 1.22.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When the FamilyOperandTypeChecker is used to check single operand data type,
> support implicit type coercion if we can.
> Now some of the sql operator override method #checkOperandTypes, and use the
> SqlSingleOperandTypeChecker#checkSingleOperandType to check the operand data
> type, we should support the implicit type coercion for these operators.
> One impl that need to note:
> we seem always pass the "iformalOperand" as "0" with method
> SqlSingleOperandTypeChecker#checkSingleOperandType when check the single
> operand, we need to pass in the real operand index in the call to the checker.
>
> Final solution:
> Caution that we could not(shouldn't) implement implicit type coercion for
> this checker,
> implicit type coercion has side effect(modify the AST), if this single
> operand checker is
> subsumed in a composite rule(OR or AND), we can not make any side effect if we
> can not make sure that all the single operands type check are passed(with
> type coercion).
> But there is an exception: only if the call has just one operand, for this
> case,
> use \{@link SqlOperandTypeChecker#checkOperandTypes} instead.
> We decide to fix these operators separately.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
