Julian Hyde commented on CALCITE-3340:

I don't really understand any of this case. Let's start with the first line, 
"COLLECTION_TABLE(TABLE syntax)". "COLLECTION_TABLE" isn't a keyword in SQL, so 
I'm totally confused.

Then the description starts talking about code, e.g. what particular lines of 
SqlValidatorImpl are doing or should be doing.

Can we start with a goal, e.g. a particular SQL query that we wish to be able 
to run, and the results it should give.

> Make TUMBLE be accepted as an operand for COLLECTION_TABLE(TABLE syntax) in 
> validator
> -------------------------------------------------------------------------------------
>                 Key: CALCITE-3340
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3340
>             Project: Calcite
>          Issue Type: Sub-task
>            Reporter: Rui Wang
>            Assignee: Rui Wang
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
> For query:
> (note reuse TUMBLE operator than use a new unresolved one)
> Calcite validator will does a step to do registration and 
> "TABLE(TUMBLE(...))" will hit [1], where "TUMBLE(...)" will be passed to [2] 
> again but there is no matching  Sqlkind handling for "TUMBLE" (note that 
> TUMBLE's node kind is TUMBLE). 
> It seems we should support TUMBLE in [2]. The details of how to support it 
> needs a bit more discussion and prototyping.
> [1]: 
> https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java#L2244
> [2]:https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java#L2031

This message was sent by Atlassian Jira

Reply via email to