[ 
https://issues.apache.org/jira/browse/CALCITE-3349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16931726#comment-16931726
 ] 

Shuyi Chen edited comment on CALCITE-3349 at 9/17/19 6:22 PM:
--------------------------------------------------------------

Hi [~ZhenqiuHuang], I suggest implement SqlExecutableStatement for 
Sql\{Create/Drop}Function, and throw an exception to expose the problem 
explicitly. And then create a subsequent Jira to implement the execute() 
function. 

 

I understand it's not the intention of this PR, but given the reviewer resource 
as well as the size of the suggested changes, I think we can combine them in 
one PR. What do you think?


was (Author: suez1224):
Hi [~ZhenqiuHuang], I suggest implement SqlExecutableStatement for 
Sql\{Create/Drop}Function, and throw an exception to expose the problem 
explicitly. And then create a subsequent Jira to implement the execute() 
function. 

> Add Function DDL into SqlKind DDL enum
> --------------------------------------
>
>                 Key: CALCITE-3349
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3349
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>            Reporter: Zhenqiu Huang
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Currently, Create Function, Drop Function are not added into SqlKind DDL 
> enum. 



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Reply via email to