jin xing created CALCITE-3357:

             Summary: Trivial null checking in RelSet#addAbstractConverters
                 Key: CALCITE-3357
                 URL: https://issues.apache.org/jira/browse/CALCITE-3357
             Project: Calcite
          Issue Type: Bug
          Components: core
            Reporter: jin xing

In current code of *RelSet#addAbstractConverters*, null checking of 
*curRelTrait* happens after clause of assert *curRelTrait.getTraitDef() == 

It makes more sense to adjust the order;

In my understanding, this issue was not found previously for two reasons:
 # AbstractConverter is not enabled by default 
 # It rarely happens that two algebra expression operators have identical 
semantics but different *RelTraitDef*

This message was sent by Atlassian Jira

Reply via email to