[
https://issues.apache.org/jira/browse/CALCITE-3365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16937068#comment-16937068
]
Lindsey Meyer commented on CALCITE-3365:
----------------------------------------
Looks good to me, thank you [~julianhyde]!!
> Don't require use of JdbcSchema in QuerySqlStatisticProvider
> ------------------------------------------------------------
>
> Key: CALCITE-3365
> URL: https://issues.apache.org/jira/browse/CALCITE-3365
> Project: Calcite
> Issue Type: Improvement
> Reporter: Lindsey Meyer
> Assignee: Julian Hyde
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.22.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> We're trying to pass in schema data manually to process queries for BigQuery,
> but that causes problems in the QuerySqlStatisticProvider because it requires
> a JdbcSchema in order to get the dialect and dataSource, as well as using a
> Jdbc Builder.
> I propose refactoring QuerySqlStatisticProvider to grab the dialect and
> dataSource using unwrap on the schema instead, so that any schema that
> implements unwrap methods for these types will work with
> QuerySqlStatisticProvider. As well as using a generic RelBuilder, instead of
> a JDBC_BUILDER.
> cc [~julianhyde] since we have been discussing this
> I've opened a PR at https://github.com/apache/calcite/pull/1467
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
