[ https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16943729#comment-16943729 ]
Haisheng Yuan commented on CALCITE-2970: ---------------------------------------- The analysis and solution looks valid at first glance, but it actually remove the usage of abstract converter by directly adding sort operator for the inputs of SortMergeJoin, thus it doesn't solve the issue fundamentally. Even if we agree on the solution, what about the distribution? You have to create an exchange operator on the inputs of MergeJoin, HashJoin and NestedLoopJoin, as well as aggregate. > Performance issue when enabling abstract converter for EnumerableConvertion > --------------------------------------------------------------------------- > > Key: CALCITE-2970 > URL: https://issues.apache.org/jira/browse/CALCITE-2970 > Project: Calcite > Issue Type: Bug > Components: core > Reporter: Haisheng Yuan > Priority: Major > Labels: pull-request-available > Time Spent: 1h 20m > Remaining Estimate: 0h > > If we enable the use of abstract converter for {{EnumerableConvention}}, by > making {{useAbstractConvertersForConversion}} return true, > {{JDBCTest.testJoinManyWay}} will not complete. -- This message was sent by Atlassian Jira (v8.3.4#803005)