[ 
https://issues.apache.org/jira/browse/CALCITE-3382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16945140#comment-16945140
 ] 

Rui Wang commented on CALCITE-3382:
-----------------------------------

I see. Let me add more comments to have a record of design decision in that PR 
and I will use "$TUMBLE". Will let you know once I finish it.

Regarding to HOP, I prefer to leave it after the full TUMBLE Table function is 
supported. It could still require changes to close this JIRA when starting 
supporting TUMBLE table function. 

After TUMBLE table function is fully supported. HOP changes will be one or a 
few easy-to-review PR.

> Rename current TUMBLE to "TUMBLE_OLD" and add TUMBLE to Parser
> --------------------------------------------------------------
>
>                 Key: CALCITE-3382
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3382
>             Project: Calcite
>          Issue Type: Sub-task
>            Reporter: Rui Wang
>            Assignee: Rui Wang
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> Per discussion in https://github.com/apache/calcite/pull/1457, we should add 
> TUMBLE to parser and rename it to "TUMBLE_OLD".
> "TUMBLE" as an operator name will be left for table-value function TUMBLE.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to