[ 
https://issues.apache.org/jira/browse/CALCITE-3404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16949954#comment-16949954
 ] 

Danny Chen commented on CALCITE-3404:
-------------------------------------

Julian, i have did some refactoring for the code, hopes it worked.

I also noticed that there are so many code to use checkPlanning in 
RelOptRulesTest, maybe it needs a refactoring just like CALCITE-3327.

> Treat agg expressions that can ignore distinct constraint as distinct in 
> AggregateExpandDistinctAggregatesRule when all the other agg expressions are 
> distinct and have same arguments
> --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CALCITE-3404
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3404
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.21.0
>            Reporter: Danny Chen
>            Assignee: Danny Chen
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.22.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> After CALCITE-3159, the distinct constraint for MAX/MIN/BIT_OR/BIT_AND are 
> removed automatically, so if we have a query:
> {code:sql}
> select sum(distinct deptno), count(distinct deptno), max(deptno) from emp
> {code}
> The plan has regression from
> {code:xml}
> LogicalAggregate(group=[{}], EXPR$0=[SUM($0)], EXPR$1=[COUNT($0)], 
> EXPR$2=[MAX($0)])
>   LogicalAggregate(group=[{0}])
>     LogicalProject(DEPTNO=[$7])
>       LogicalTableScan(table=[[CATALOG, SALES, EMP]])
> {code}
> to
> {code:xml}
> LogicalAggregate(group=[{}], EXPR$0=[SUM($0) FILTER $2], EXPR$1=[COUNT($0) 
> FILTER $2], EXPR$2=[MIN($1) FILTER $3])
>   LogicalProject(DEPTNO=[$0], EXPR$2=[$1], $g_0=[=($2, 0)], $g_1=[=($2, 1)])
>     LogicalAggregate(group=[{0}], groups=[[{0}, {}]], EXPR$2=[MAX($0)], 
> $g=[GROUPING($0)])
>       LogicalProject(DEPTNO=[$7])
>         LogicalTableScan(table=[[CATALOG, SALES, EMP]])
> {code}
> The distinct trait actually can be reused.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to