[
https://issues.apache.org/jira/browse/CALCITE-3403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16952384#comment-16952384
]
Julian Hyde commented on CALCITE-3403:
--------------------------------------
The change can stand. I see now why {{RelOptCluster.getMetadataQuery()}} is
more efficient than {{RelMetadataQuery.instance()}}. And it's harmless to call
it from deprecated methods.
> WindowReduceExpressionsRule does not reuse RelMetadataQuery
> -----------------------------------------------------------
>
> Key: CALCITE-3403
> URL: https://issues.apache.org/jira/browse/CALCITE-3403
> Project: Calcite
> Issue Type: Improvement
> Reporter: Haisheng Yuan
> Assignee: jin xing
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.22.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> It creates a new RelMetadataQuery instance, which is a fresh RelMetadataQuery
> without any data cache. We should get RelMetadataQuery from RelOptRuleCall to
> reuse cache as much as possible.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
