[
https://issues.apache.org/jira/browse/CALCITE-3334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953090#comment-16953090
]
Julian Hyde commented on CALCITE-3334:
--------------------------------------
I haven't had time to review the PR in depth, but getting rid of
MaterializedViewSubstitutionVisitor makes sense.
For the purposes of backward compatibility, is it possible to keep it,
deprecated? Perhaps it could be a trivial sub-class of SubstitutionVisitor?
Can someone else please review and commit the PR.
> Refinement for Substitution-Based MV Matching
> ---------------------------------------------
>
> Key: CALCITE-3334
> URL: https://issues.apache.org/jira/browse/CALCITE-3334
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Reporter: jin xing
> Assignee: jin xing
> Priority: Major
> Labels: pull-request-available
> Time Spent: 3h
> Remaining Estimate: 0h
>
> The approach of substitution-based MV matching is an effective way for its
> simplicity and extensibility.
> This JIRA proposes to refine existing implementation by several points:
> # Canonicalize before MV matching -- by such canonicalization we can
> significantly simplify the algebra tree and lower the difficulty for
> materialization matching.
> # Separate matching rules into two categories and enumerate common matching
> patterns which need to be covered by rules.
> Please check the design doc: [Design
> Doc|https://docs.google.com/document/d/1JpwGNFE3hw3yXb7W3-95-jXKClZC5UFPKbuhgYDuEu4/edit#]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
