[
https://issues.apache.org/jira/browse/CALCITE-3412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953504#comment-16953504
]
Julian Hyde edited comment on CALCITE-3412 at 10/17/19 8:34 AM:
----------------------------------------------------------------
I agree with [~kofiori] that {{FLOOR(timestamp TO WEEK)}} should round to the
previous Sunday, regardless of locale. This is consistent with {{EXTRACT(DOW
FROM timestamp)}} as described in CALCITE-2303.
I have created a fix in
[https://github.com/julianhyde/calcite/tree/3412-floor-timestamp], which can be
merged after avatica-1.16 is released (see CALCITE-3398).
The fix also fixes FLOOR(date TO YEAR), FLOOR(date TO QUARTER), FLOOR(date TO
MONTH), FLOOR(date TO WEEK).
was (Author: julianhyde):
I agree with [~kofiori] that {{FLOOR(timestamp TO WEEK)}} should round to the
previous Sunday, regardless of locale. This is consistent with {{EXTRACT(DOW
FROM timestamp)}} as described in CALCITE-2303.
I have created a fix in
[https://github.com/julianhyde/calcite/tree/3412-floor-timestamp], which can be
merged after avatica-1.16 is released (see CALCITE-3398).
> FLOOR(timestamp TO WEEK) gives wrong result
> -------------------------------------------
>
> Key: CALCITE-3412
> URL: https://issues.apache.org/jira/browse/CALCITE-3412
> Project: Calcite
> Issue Type: Bug
> Components: core
> Reporter: huaicui
> Assignee: Julian Hyde
> Priority: Major
> Fix For: 1.22.0
>
> Attachments: image-2019-10-15-13-33-34-896.png
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Floor timestamp to week exist error:
> The start day of the week is not Sunday or Monday, calcite use Thursday to
> split a week.
> Example:
> sql: select FLOOR(CAST('2017-01-28' AS TIMESTAMP) TO WEEK);
> Response:
> 2017-01-26 00:00:00.0
>
> 2017-01-26 is Tuesday that is not our expect result. As result, 2017-01-22 is
> the first day that we expect.
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
