[ 
https://issues.apache.org/jira/browse/CALCITE-3432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16955676#comment-16955676
 ] 

Julian Hyde commented on CALCITE-3432:
--------------------------------------

I don't think this is a useful change. People might accidentally create a 
RexBuilder with a different type factory than is used elsewhere in their code.

There's probably some code in {{Planner}} or {{Frameworks}} that creates a 
{{RelDataTypeFactory}}, {{RexBuilder}} and other objects that people might 
need, such as {{RelBuilder}}.

Or you can add it to your own utility class. I'd recommend that you add javadoc 
explaining what it is doing.

> RexBuilder construct method with the default of RelDataTypeFactory.
> -------------------------------------------------------------------
>
>                 Key: CALCITE-3432
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3432
>             Project: Calcite
>          Issue Type: Wish
>            Reporter: xzh_dz
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> RexBuilder construct method with the default of RelDataTypeFactory.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to