[
https://issues.apache.org/jira/browse/CALCITE-3436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16959189#comment-16959189
]
Julian Hyde commented on CALCITE-3436:
--------------------------------------
[~fib-seq], I have reworked a little in
https://github.com/julianhyde/calcite/tree/3436-connection-properties. I added
an {{isSet}} method so that we do not have to delve into the {{Properties}},
which I think of as internals. Please take a look.
> CalciteConnectionConfigImpl.set obliterates previous property values
> --------------------------------------------------------------------
>
> Key: CALCITE-3436
> URL: https://issues.apache.org/jira/browse/CALCITE-3436
> Project: Calcite
> Issue Type: Bug
> Reporter: Ryan Fu
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The cause is that `new Properties(properties)` doesn't copy the previous
> value as, say, `new HashMap(map)` does.
>
> * Add a unit test in PlannerTest, that if you call set(x, 1) then set(y, 2)
> on a CalciteConnectionConfigImpl, the result contains x and y.
> * Consider potentially using `clone()` as Properties implements Cloneable
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
