[
https://issues.apache.org/jira/browse/CALCITE-3469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16964681#comment-16964681
]
Jin Xing commented on CALCITE-3469:
-----------------------------------
BTW, we don't need to include 'Fix' in the Jira title.
> Fix typo in SubstitutionVisitor#rowTypesAreEquivalent
> -----------------------------------------------------
>
> Key: CALCITE-3469
> URL: https://issues.apache.org/jira/browse/CALCITE-3469
> Project: Calcite
> Issue Type: Bug
> Components: core
> Reporter: daimin
> Priority: Minor
>
> {code:java}
> private boolean rowTypesAreEquivalent(
> MutableRel rel0, MutableRel rel1, Litmus litmus) {
> if (rel0.rowType.getFieldCount() != rel1.rowType.getFieldCount()) {
> return litmus.fail("Mismatch for column count: [{}]", Pair.of(rel0,
> rel1));
> }
> for (Pair<RelDataTypeField, RelDataTypeField> pair
> : Pair.zip(rel0.rowType.getFieldList(), rel0.rowType.getFieldList()))
> {
> if (!pair.left.getType().equals(pair.right.getType())) {
> return litmus.fail("Mismatch for column type: [{}]", Pair.of(rel0,
> rel1));
> }
> }
> return litmus.succeed();
> }
> {code}
> Where
> {code:java}
> Pair.zip(rel0.rowType.getFieldList(), rel0.rowType.getFieldList())
> {code}
> should be
> {code:java}
> Pair.zip(rel0.rowType.getFieldList(), rel1.rowType.getFieldList())
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
