[ 
https://issues.apache.org/jira/browse/CALCITE-3483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Haisheng Yuan updated CALCITE-3483:
-----------------------------------
    Description: RexLiteral may be sub-classed and some methods may be 
overrode. e.g. {{printAsJava}}. But currently, RexLiteral fields are private, 
sub-classes can't access these fields, which makes methods like {{printAsJava}} 
meaningless to be overrode. We recommend make RexLiteral member fields 
protected, so that we can sub-class it, and customize the behavior of methods 
such as {{printAsJava}}. Does it make sense?  (was: RexLiteral may be 
sub-classed and some methods may be overrode. e.g. {{printAsJava}}. But 
currently, RexLiteral fields are private, sub-classes can't access these 
fields, which makes methods like {{printAsJava}} unable to be overrode. We 
recommend make RexLiteral member fields protected, so that we can sub-class it, 
and customize the behavior of methods such as {{printAsJava}}. Does it make 
sense?)

> Make RexLiteral member fields accessible by sub-class
> -----------------------------------------------------
>
>                 Key: CALCITE-3483
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3483
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>            Reporter: Haisheng Yuan
>            Priority: Major
>
> RexLiteral may be sub-classed and some methods may be overrode. e.g. 
> {{printAsJava}}. But currently, RexLiteral fields are private, sub-classes 
> can't access these fields, which makes methods like {{printAsJava}} 
> meaningless to be overrode. We recommend make RexLiteral member fields 
> protected, so that we can sub-class it, and customize the behavior of methods 
> such as {{printAsJava}}. Does it make sense?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to