[ 
https://issues.apache.org/jira/browse/CALCITE-3456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16972934#comment-16972934
 ] 

Danny Chen commented on CALCITE-3456:
-------------------------------------

It is the SqlToRelConverter that throws the error. The BlackBoard reuse a wrong 
IN subquery for the aggregation and the input refs in the IN RexCall have the 
wrong shift. So finally there is a type equivalence comparison failure and the 
error throws. Here is the stack trace:

{code:java}
java.lang.AssertionError: type mismatch:
ref:
VARCHAR(10) NOT NULL
input:
BIGINT NOT NULL

        at org.apache.calcite.util.Litmus$1.fail(Litmus.java:31)
        at org.apache.calcite.plan.RelOptUtil.eq(RelOptUtil.java:2033)
        at org.apache.calcite.rex.RexChecker.visitInputRef(RexChecker.java:125)
        at org.apache.calcite.rex.RexChecker.visitInputRef(RexChecker.java:57)
        at org.apache.calcite.rex.RexInputRef.accept(RexInputRef.java:112)
        at org.apache.calcite.rex.RexChecker.visitCall(RexChecker.java:140)
        at org.apache.calcite.rex.RexChecker.visitCall(RexChecker.java:57)
        at org.apache.calcite.rex.RexCall.accept(RexCall.java:191)
        at org.apache.calcite.rex.RexChecker.visitCall(RexChecker.java:140)
        at org.apache.calcite.rex.RexChecker.visitCall(RexChecker.java:57)
        at org.apache.calcite.rex.RexCall.accept(RexCall.java:191)
        at org.apache.calcite.rex.RexChecker.visitCall(RexChecker.java:140)
        at org.apache.calcite.rex.RexChecker.visitCall(RexChecker.java:57)
        at org.apache.calcite.rex.RexCall.accept(RexCall.java:191)
        at org.apache.calcite.rel.core.Project.isValid(Project.java:218)
        at org.apache.calcite.rel.core.Project.<init>(Project.java:91)
        at 
org.apache.calcite.rel.logical.LogicalProject.<init>(LogicalProject.java:66)
        at 
org.apache.calcite.rel.logical.LogicalProject.<init>(LogicalProject.java:83)
        at 
org.apache.calcite.rel.logical.LogicalProject.create(LogicalProject.java:132)
        at 
org.apache.calcite.rel.logical.LogicalProject.create(LogicalProject.java:120)
        at 
org.apache.calcite.rel.core.RelFactories$ProjectFactoryImpl.createProject(RelFactories.java:158)
        at org.apache.calcite.tools.RelBuilder.project(RelBuilder.java:1415)
        at org.apache.calcite.tools.RelBuilder.project(RelBuilder.java:1253)
        at 
org.apache.calcite.sql2rel.SqlToRelConverter.createAggImpl(SqlToRelConverter.java:3022)
        at 
org.apache.calcite.sql2rel.SqlToRelConverter.convertAgg(SqlToRelConverter.java:2844)
        at 
org.apache.calcite.sql2rel.SqlToRelConverter.convertSelectImpl(SqlToRelConverter.java:684)
        at 
org.apache.calcite.sql2rel.SqlToRelConverter.convertSelect(SqlToRelConverter.java:646)
        at 
org.apache.calcite.sql2rel.SqlToRelConverter.convertQueryRecursive(SqlToRelConverter.java:3230)
        at 
org.apache.calcite.sql2rel.SqlToRelConverter.convertQuery(SqlToRelConverter.java:572)
        at 
org.apache.calcite.test.SqlToRelTestBase$TesterImpl.convertSqlToRel(SqlToRelTestBase.java:626)
        at 
org.apache.calcite.test.SqlToRelTestBase$TesterImpl.assertConvertsTo(SqlToRelTestBase.java:745)
        at 
org.apache.calcite.test.SqlToRelConverterTest$Sql.convertsTo(SqlToRelConverterTest.java:3640)
        at 
org.apache.calcite.test.SqlToRelConverterTest$Sql.ok(SqlToRelConverterTest.java:3632)
        at 
org.apache.calcite.test.SqlToRelConverterTest.testAggregateWithSameDigestInSubQueries(SqlToRelConverterTest.java:3574)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
        at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
        at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
        at 
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
        at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
        at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
        at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
        at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
        at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
        at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
        at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
        at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
        at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
        at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
{code}


> AssertionError throws for aggregation with same digest IN subqueries in same 
> scope
> ----------------------------------------------------------------------------------
>
>                 Key: CALCITE-3456
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3456
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.21.0
>            Reporter: Danny Chen
>            Assignee: Danny Chen
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.22.0
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Check this sql in SqlToRelConverterTest:
> {code:java}
> @Test public void testAggregateWithCaseWhen() {
>     final String sql = "select\n"
>         + "  CASE WHEN job IN ('810000', '820000') THEN job\n"
>         + "   ELSE 'error'\n"
>         + "  END AS id,\n"
>         + "  count(empno)\n"
>         + "FROM emp\n"
>         + "where job <> '' or job in ('810000', '820000')\n"
>         + "GROUP by deptno, job";
>     sql(sql).ok();
>   }
> {code}
> I tested PostgreSQL 9.6 and MySQL 5.6, this is a valid SQL and they both 
> outputs the right result.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to