[ 
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16973551#comment-16973551
 ] 

Xiening Dai commented on CALCITE-2970:
--------------------------------------

"Currently if we have 3 conventions we already have XSortRule, YSortRule, 
ZSortRule etc. so I don't think this is a big problem."

It's not only these. Remember that abstract converter is capable of converting 
to a trait set. If you have multiple target traits, e.g. distribution and 
collation, then you we will need XExchangeSort, YExchangeSort, ZExchangeSort, 
etc. 

I can work on a PR with my proposal, but before that want to make sure everyone 
agrees on the direction.

> Performance issue when enabling abstract converter for EnumerableConvention
> ---------------------------------------------------------------------------
>
>                 Key: CALCITE-2970
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2970
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>            Reporter: Haisheng Yuan
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> If we enable the use of abstract converter for {{EnumerableConvention}}, by 
> making {{useAbstractConvertersForConversion}} return true, 
> {{JDBCTest.testJoinManyWay}} will not complete.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to