[ https://issues.apache.org/jira/browse/CALCITE-3491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Haisheng Yuan resolved CALCITE-3491. ------------------------------------ Fix Version/s: 1.22.0 Resolution: Fixed Fixed in https://github.com/apache/calcite/commit/301bbe9e132346f60587e8c21c474f7c51b236c3. > VolcanoPlanner.completeConversion() is bypassed by "if (true)" > -------------------------------------------------------------- > > Key: CALCITE-3491 > URL: https://issues.apache.org/jira/browse/CALCITE-3491 > Project: Calcite > Issue Type: Improvement > Reporter: Xiening Dai > Priority: Major > Labels: pull-request-available > Fix For: 1.22.0 > > Time Spent: 1h > Remaining Estimate: 0h > > Not very clear about why we need VolcanoPlanner.completeConversion(). It's > currently bypassed as below[1] - > if (true) { > return rel; > } > If the method is not needed, we should just remove it. > [1] > https://github.com/apache/calcite/blob/f90e5d7b48848191c1a70e6c0f78eece93433806/core/src/main/java/org/apache/calcite/plan/volcano/VolcanoPlanner.java#L1096 -- This message was sent by Atlassian Jira (v8.3.4#803005)