[
https://issues.apache.org/jira/browse/CALCITE-3492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16976836#comment-16976836
]
Julian Hyde commented on CALCITE-3492:
--------------------------------------
A minor point. Use active voice. Rather than "Exception thrown when terms has 1
RexNode in RexUtil.simplifyOrs()" write "RexUtil.simplifyOrs() throws if terms
has 1 RexNode". Shorter and more information (it says what throws). (This
description was pretty good. It's just interesting that active voice makes
documentation better.)
> Exception thrown when terms has 1 RexNode in RexUtil.simplifyOrs()
> ------------------------------------------------------------------
>
> Key: CALCITE-3492
> URL: https://issues.apache.org/jira/browse/CALCITE-3492
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Reporter: Haisheng Yuan
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> This is a regression caused by the refactoring in 1.20.0.
> When {{terms}} has only 1 element, it will throw an exception. We discovered
> the issue when trying to upgrade Calcite.
> {code:java}
> public static RexNode simplifyOrs(RexBuilder rexBuilder,
> List<RexNode> terms) {
> return new RexSimplify(rexBuilder, RelOptPredicateList.EMPTY, EXECUTOR)
> .simplifyUnknownAs(rexBuilder.makeCall(SqlStdOperatorTable.OR, terms),
> RexUnknownAs.UNKNOWN);
> }
> {code}
> We can't assume the {{terms}} always has more than 1 element. Although this
> method is deprecated, I think we need to correct the regression. Maybe we
> don't need a test case, given it is a deprecated method.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
