[ 
https://issues.apache.org/jira/browse/CALCITE-3339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16980687#comment-16980687
 ] 

Rui Wang commented on CALCITE-3339:
-----------------------------------

[~julianhyde]

Ok. Now I have merged everything into the TUMBLE branch 
(https://github.com/apache/calcite/pull/1587). Sorry I have created too much 
PRs as I wasn't sure how to proceed with a complicated change.

In #1587, now it supports table-valued function TUMBLE plus DESCRIPTOR plus a 
stream.iq test. I have also addressed your comments there including:
1. add test in SqlParserTest
2. add test in SqlValidatorTest
3. change return type of DESCRIPTOR to SqlTypeName.COLUMN_LIST.
4. add javadoc for SqlDescriptorOperator and update user-facing 
doc(reference.md).


> DESCRIPTOR as a SQL operator in SqlStdOperatorTable
> ---------------------------------------------------
>
>                 Key: CALCITE-3339
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3339
>             Project: Calcite
>          Issue Type: Sub-task
>            Reporter: Rui Wang
>            Assignee: Rui Wang
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> For query:
> SELECT * 
> FROM TABLE(TUMBLE_TVF(
>         TABLE ORDERS,
>         DESCRIPTOR(ROWTIME), 
>         INTERVAL '10' MINUTE))
> TABLE ORDERS is converted to SqlPrefixOperator, but DESCRIPTOR(ROWTIME) has 
> no mapping in SqlStdOperatorTable. 
> There are two options:
> 1. There is a SqlColumnListConstructor which serves the same(similar) purpose 
> to specific a list of column. 
> 2. We create a new operator for DESCRIPTOR.
> Reuse existing code is always good so we can start from option one and see if 
> it works.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to